Re: [PATCH linux-next] xfrm: Remove redundant fields and related parentheses

From: Steffen Klassert
Date: Mon Oct 25 2021 - 04:20:55 EST


On Fri, Oct 22, 2021 at 09:59:11AM +0000, luo penghao wrote:
> The variable err is not necessary in such places. It should be revmoved
> for the simplicity of the code. This will cause the double parentheses
> to be redundant, and the inner parentheses should be deleted.
>
> The clang_analyzer complains as follows:
>
> net/xfrm/xfrm_input.c:533: warning:
> net/xfrm/xfrm_input.c:563: warning:
>
> Although the value stored to 'err' is used in the enclosing expression,
> the value is never actually read from 'err'.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: luo penghao <luo.penghao@xxxxxxxxxx>

Is this an update to your previous patch?
If so, please mark it as such with a 'v2'
and describe what changed.

Thanks!