Re: [PATCH 4/4] MAINTAINERS: Add git tree and missing files for KPROBES

[Tiezhu Yang]

On 10/25/2021 02:38 PM, Masami Hiramatsu wrote:
> On Mon, 25 Oct 2021 11:31:00 +0800
> Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:
>
> > There is no git tree for KPROBES in MAINTAINERS, it is not convinent to
> > rebase, lib/test_kprobes.c and samples/kprobes belong to kprobe, add them.
> >
> > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> > ---
> >   MAINTAINERS | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4372473..0e9bc60 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10506,10 +10506,13 @@ M:	Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>
> >   M:	"David S. Miller" <davem@xxxxxxxxxxxxx>
> >   M:	Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> >   S:	Maintained
> > +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git
> NACK. As I said, this branch was prepared when I discussed with tip maintainer
> on kretprobe stackfix series but now it has been maintained on Steve's tracing
> tree.
>
> Steve, should we put your tree here?

If yes, should I update patch #4 and then send a v2 version of this 
patch set?

@@ -10505,11 +10505,16 @@ M:    Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxx>
 M:     Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>
 M:     "David S. Miller" <davem@xxxxxxxxxxxxx>
 M:     Masami Hiramatsu <mhiramat@xxxxxxxxxx>
+L:     linux-trace-devel@xxxxxxxxxxxxxxx
 S:     Maintained
+Q:     https://patchwork.kernel.org/project/linux-trace-devel/list/
+T:     git 
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
 F:     Documentation/trace/kprobes.rst
 F:     include/asm-generic/kprobes.h
 F:     include/linux/kprobes.h
 F:     kernel/kprobes.c
+F:     lib/test_kprobes.c
+F:     samples/kprobes

By the way, it seems that we should also update the TRACING git tree [1]?
If yes, should I send the following change as a new patch #5 in the v2 
version
or do the following change in the above patch #4?

@@ -19065,8 +19070,10 @@ F:     drivers/char/tpm/
 TRACING
 M:     Steven Rostedt <rostedt@xxxxxxxxxxx>
 M:     Ingo Molnar <mingo@xxxxxxxxxx>
+L:     linux-trace-devel@xxxxxxxxxxxxxxx
 S:     Maintained
-T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 
perf/core
+Q:     https://patchwork.kernel.org/project/linux-trace-devel/list/
+T:     git 
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
 F:     Documentation/trace/ftrace.rst
 F:     arch/*/*/*/ftrace.h
 F:     arch/*/kernel/ftrace.c

 [1] 
https://lore.kernel.org/lkml/20211019091344.65629198@xxxxxxxxxxxxxxxxxx/

 Thanks,
 Tiezhu

> Anyway, I will pick your [1/4]-[3/4].
>
> Thank you,
>
> >   F:	Documentation/trace/kprobes.rst
> >   F:	include/asm-generic/kprobes.h
> >   F:	include/linux/kprobes.h
> >   F:	kernel/kprobes.c
> > +F:	lib/test_kprobes.c
> > +F:	samples/kprobes
> >   
> >   KS0108 LCD CONTROLLER DRIVER
> >   M:	Miguel Ojeda <ojeda@xxxxxxxxxx>
> > --
> > 2.1.0