Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp firmware

[Greg KH]

On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote:
> Hi Greg,
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Monday, October 25, 2021 2:05 PM
> > To: Abhyuday Godhasara <agodhasa@xxxxxxxxxx>
> > Cc: Michal Simek <michals@xxxxxxxxxx>; Rajan Vaja <RAJANV@xxxxxxxxxx>;
> > Manish Narani <MNARANI@xxxxxxxxxx>; zou_wei@xxxxxxxxxx; Sai Krishna
> > Potthuri <lakshmis@xxxxxxxxxx>; Jiaying Liang <jliang@xxxxxxxxxx>; Jiaying Liang
> > <jliang@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
> > kernel@xxxxxxxxxxxxxxxxxxx; Tejas Patel <TEJASP@xxxxxxxxxx>
> > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp
> > firmware
> > 
> > On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote:
> > > In zynqmp-firmware, register notifier is not supported, add support of
> > > register notifier in zynqmp-firmware.
> > >
> > > Signed-off-by: Tejas Patel <tejas.patel@xxxxxxxxxx>
> > > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xxxxxxxxxx>
> > > Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>
> > > ---
> > > Changes in v6:
> > > - Minor fix
> > 
> > 
> > That is vague, what got "fixed" here?
> [Abhyuday] During rebase of patches on your tree couple of lines code was get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git am -3".
> I corrected the below code which was wrong in previous patch v5.
> +static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> +					      const u32 wake, const u32 enable) {
> +	return -ENODEV;
> +}
> 
> In v5 it was like below, which is wrong
> static inline int zynqmp_pm_load_pdi(const u32 src, const u64 address)
> static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> 					      const u32 wake, const u32 enable) {
> 	return -ENODEV;
> }
> So, the body was missing here for zynqmp_pm_load_pdi in v5.

And why did you not describe this in the changelog text?  That is what I
was asking about here.  Please be specific, as reviewers need to know
this type of thing.

thanks,

greg k-h