Re: [PATCH v2] dma-buf: move dma-buf symbols into the DMA_BUF module namespace
From: Greg Kroah-Hartman
Date: Mon Oct 25 2021 - 08:52:38 EST
On Mon, Oct 25, 2021 at 05:43:49PM +0530, Sumit Semwal wrote:
> Hi Greg,
>
> On Mon, 25 Oct 2021 at 16:29, Christian König <christian.koenig@xxxxxxx> wrote:
> >
> > Am 25.10.21 um 12:36 schrieb Greg Kroah-Hartman:
> > > On Sun, Oct 10, 2021 at 02:46:28PM +0200, Greg Kroah-Hartman wrote:
> > >> In order to better track where in the kernel the dma-buf code is used,
> > >> put the symbols in the namespace DMA_BUF and modify all users of the
> > >> symbols to properly import the namespace to not break the build at the
> > >> same time.
> > >>
> > >> Now the output of modinfo shows the use of these symbols, making it
> > >> easier to watch for users over time:
> > >>
> > >> $ modinfo drivers/misc/fastrpc.ko | grep import
> > >> import_ns: DMA_BUF
> > >>
> > >> Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>
> > >> Cc: David Airlie <airlied@xxxxxxxx>
> > >> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > >> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> > >> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > >> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> > >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > >> Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > >> Acked-by: Christian König <christian.koenig@xxxxxxx>
> > >> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> > >> Acked-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> > >> Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > >> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > >> ---
> > >> v2: added lots of acks
> > >> added 2 more drivers that needed the change, as found by Arnd
> > > Ping? Any ideas on what needs to happen to get this into the tree?
> > >
> > > Or can I take it through my char-misc tree? I seem to have a bunch of
> > > acks on it by the respective maintainers...
> >
> > I could push that upstream through the drm-misc-next tree if you like,
> > but honestly char-misc sounds like the better approach since this
> > touches a lot of drivers outside of drm as well.
>
> I agree with Christian here - char-misc might be a better way for this.
Good idea, I'll take it through this tree as it will need to add the
symbol to the habanalabs driver at the same time as it has picked up
support for these symbols in my tree.
thanks,
greg k-h