Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv)

From: Paolo Bonzini
Date: Mon Oct 25 2021 - 10:22:18 EST


On 09/10/21 04:12, Sean Christopherson wrote:
+ /* TODO: Document why the unblocking path checks for updates. */

Is that a riddle or what? :)

Paolo

+ if (kvm_vcpu_is_blocking(vcpu) &&
+ kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) {
+ kvm_vcpu_update_apicv(vcpu);
+
+ if (!kvm_vcpu_apicv_active(vcpu))
+ return;
+ }
+