Re: Commit 0d989ac2c90b broke my x86-64 build.

From: Josh Poimboeuf
Date: Mon Oct 25 2021 - 10:47:15 EST


On Mon, Oct 25, 2021 at 11:04:33AM +0200, Peter Zijlstra wrote:
> On Sun, Oct 24, 2021 at 09:51:45PM -0500, Rob Landley wrote:
> > > Unfortunately I think CONFIG_STACK_VALIDATION is no longer optional on
> > > x86-64 these days, because of static calls and retpolines.
> >
> > Does it need stack validation, or just a frame unwinder?
>
> static_calls rely on objtool to find all "call __SCT*" instructions and
> write their location in a .static_call_sites section.
>
> The having of static calls is not optional on x86_64, and I have zero
> interest in trying to work out what not having static_call() does, or to
> maintain that option.

What I meant was, make STATIC_CALL_INLINE optional. Then it would use
out-of-line static calls which should just work, no?

--
Josh