Re: [PATCH v2] slob: add size header to all allocations

From: Rustam Kovhaev
Date: Mon Oct 25 2021 - 17:49:41 EST


On Mon, Oct 25, 2021 at 11:36:53AM +0200, Vlastimil Babka wrote:
> On 10/23/21 08:41, Rustam Kovhaev wrote:
> > Let's prepend both kmalloc() and kmem_cache_alloc() allocations with the
> > size header.
> > It simplifies the slab API and guarantees that both kmem_cache_alloc()
> > and kmalloc() memory could be freed by kfree().
> >
> > meminfo right after the system boot, without the patch:
> > Slab: 35456 kB
> >
> > the same, with the patch:
> > Slab: 36160 kB
> >
> > Link: https://lore.kernel.org/lkml/20210929212347.1139666-1-rkovhaev@xxxxxxxxx
> > Signed-off-by: Rustam Kovhaev <rkovhaev@xxxxxxxxx>
>
> Seems overal correct to me, thanks! I'll just suggest some improvements:

Thank you, I'll send a v3.