RE: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up

[Richard Zhu]

Snipped...

> > >
> > > Hello Richard,
> > > I have one curiosity on this topic. Does this works well in case the
> > > regulator is shared? I just want to be sure that if the regulator is
> > > shared everything is working fine even if the PCI-E link is not used or not
> coming up for any reason.
> > >
> > [Richard Zhu] Hi Francesco:
> > Actually, this regulator used by i.MX PCIe controller driver is one fixed gpio
> regulator.
> > Refer to my understand, this regulator is not shared by different devices.
> >
> > Up to now, it works fine to power up the PCIe slot populated on the HW
> board.
> 
> Isn't this something that depend on the actual board design? From the driver
> point of view you should not silently enforce such design requirement on the
> board.
> Am I missing something here? Would be glad to you if you can clarify in case.
> 
[Richard Zhu] Yes, it is relied on the actual HW board design.
This regulator is one optional, not mandatory required for all the board designs.
So, there is one _enabled or not check before manipulate this regulator.

BR
Richard

> Francesco
>