Re: [PATCH] kselftests: ftrace: limit the executing time by reading from cached trace

[Masami Hiramatsu]

On Mon, 25 Oct 2021 22:17:17 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 21 Oct 2021 09:31:31 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> 
> > > > +# Stop tracing while reading the trace file by default, to prevent
> > > > +# the test results while checking it and to avoid taking a long time
> > > > +# to check the result.
> > > > +    [ -f options/pause-on-trace ] && echo 1 > options/pause-on-trace
> > > > +  
> > > 
> > > Is there a way we can save the previous setting and put it back on reset?  
> > 
> > No, since each testcase must be run under the clean state. Would we need to
> > recover the settings?
> 
> I would at least put it back to the default. If someone runs the tests,
> it should at least put it back to what it was at boot. Otherwise,
> someone might run the tests, and then wonder why events are being
> dropped when they are reading the trace.

Umm, we may need to have a knob to reset the ftrace options...
Can we warn such user that if the ftracetest finds that the current
value is not the same what it sets?

Thank you,

-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>