RE: linux-next: build failure after merge of the pinctrl tree

From: Prathamesh Shete
Date: Tue Oct 26 2021 - 08:30:17 EST


Fixed following warnings and error.
Attached the patch that fixes the issue.
Please help apply the Patch.

Thanks
Prathamesh.

-----Original Message-----
From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Sent: Tuesday, October 26, 2021 10:59 AM
To: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Kartik . <kkartik@xxxxxxxxxx>; Prathamesh Shete <pshete@xxxxxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Linux Next Mailing List <linux-next@xxxxxxxxxxxxxxx>
Subject: linux-next: build failure after merge of the pinctrl tree

Hi all,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
293 | return &pmx->soc->groups[group];
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
282 | struct tegra_pingroup *g;
| ^
drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
341 | return -EINVAL;
| ^
drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")

I have used the pinctrl tree from next-20211025 for today.
--
Cheers,
Stephen Rothwell

Attachment: 0001-pinctrl-tegra-Fix-warnings-and-error.patch
Description: 0001-pinctrl-tegra-Fix-warnings-and-error.patch