Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

[Alex Elder]

On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> From: Alex Elder <elder@xxxxxxxxxx>
>
> Add a prompt to the "tristate" attribute in the Kconfig file in
> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> without it.

This was a *long* time ago!
  https://lore.kernel.org/all/20180427140358.30839-1-elder@xxxxxxxxxx/

The discussion that followed indicated that the thing that needs
QCOM_QMI_HELPERS should *select* it rather than *depend on it.

Will this not work for you?

					-Alex

> We need it in OpenWRT project, when using WiFi backports
> and build ath11k driver. While ath11k driver depends on
> QCOM_QMI_HELPERS we need way to enable this option in
> our kernel.
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx>
> ---
>   drivers/soc/qcom/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index fe3c486ae32d..16fb8e286015 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
>   	select QCOM_QMI_HELPERS
>   
>   config QCOM_QMI_HELPERS
> -	tristate
> +	tristate "Qualcomm QMI Helpers"
>   	depends on NET
>   
>   config QCOM_RMTFS_MEM