Re: [PATCH v1 01/15] dt-bindings: add pwrseq device tree bindings

From: Dmitry Baryshkov
Date: Tue Oct 26 2021 - 10:43:01 EST


On 26/10/2021 15:53, Rob Herring wrote:
On Wed, Oct 06, 2021 at 06:53:53AM +0300, Dmitry Baryshkov wrote:
Add device tree bindings for the new power sequencer subsystem.
Consumers would reference pwrseq nodes using "foo-pwrseq" properties.
Providers would use '#pwrseq-cells' property to declare the amount of
cells in the pwrseq specifier.

Please use get_maintainers.pl.

This is not a pattern I want to encourage, so NAK on a common binding.


Could you please spend a few more words, describing what is not encouraged? The whole foo-subsys/#subsys-cells structure?

Or just specifying the common binding?



Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
.../bindings/power/pwrseq/pwrseq.yaml | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/pwrseq/pwrseq.yaml

diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq.yaml b/Documentation/devicetree/bindings/power/pwrseq/pwrseq.yaml
new file mode 100644
index 000000000000..4a8f6c0218bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/pwrseq/pwrseq.yaml
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/pwrseq/pwrseq.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Power Sequencer devices
+
+maintainers:
+ - Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
+
+properties:
+ "#powerseq-cells":
+ description:
+ Number of cells in a pwrseq specifier.
+
+patternProperties:
+ ".*-pwrseq$":
+ description: Power sequencer supply phandle(s) for this node
+
+additionalProperties: true
+
+examples:
+ - |
+ qca_pwrseq: qca-pwrseq {
+ #pwrseq-cells = <1>;
+ };
+
+ bluetooth {
+ bt-pwrseq = <&qca_pwrseq 1>;
+ };
+...
--
2.33.0




--
With best wishes
Dmitry