Re: [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines
From: Qian Cai
Date: Tue Oct 26 2021 - 11:26:21 EST
On 10/26/21 11:10 AM, Andy Shevchenko wrote:
> On Tue, Oct 26, 2021 at 10:41:08AM -0400, Qian Cai wrote:
>> Since "size" is an "unsigned int", the rvalue "size - 1" will still be
>> "unsigned int" according to the C standard (3.2.1.5 Usual arithmetic
>> conversions). Therefore, GENMASK(size - 1, 0) will always return 0UL.
>
> Huh?!
>
> Have you run test_bitmap et al., btw?
Not yet. I'll setup a VM to run it soon.