Re: [PATCH v2] staging: r8188eu: avoid use of goto statement

From: Greg KH
Date: Tue Oct 26 2021 - 12:46:50 EST


On Mon, Oct 25, 2021 at 08:06:00PM +0530, Saurav Girepunje wrote:
> Remove the goto statement from _rtw_init_cmd_priv(). In this function
> goto statement can be replace by return statement. By replacing the
> goto statement with return statement local variable "res" is also not
> required. As on goto label exit, function only return it is not
> performing any cleanup. Avoiding goto statement will simplify the function.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
> ---
>
> ChangeLog V2:
>
> -Add space after line end on changelog.
> -Remove addition blank link after the local variable res
> as per the coding guidelines for linux kernel.
>

This does not apply to my tree, please rebase and resubmit.

thanks,

greg k-h