Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus

[David Heidelberg]

thanks, I'll try to work on my commit messages :)

David


On Tue, Oct 26 2021 at 11:47:46 -0500, Alex Elder <elder@xxxxxxxx> 
wrote:
> On 10/26/21 11:32 AM, David Heidelberg wrote:
> > Fix warnings as:
> > arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 
> > 1504, 0], [21, 1506, 0]] is too long
> > 	From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
> >
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
>
> Looks good to me.  I'm not sure why the minItems is required,
> unless it's to indicate that it must be at least 1 and can't
> be missing.  But iommus is also stated to be required elsewhere
> in the binding.
>
> In the future, it's helpful to indicate the command you
> used to produce the warning in your commit message.  And
> furthermore, describing the problem (and not just including
> the error message) is even more helpful.
>
> Reviewed-by: Alex Elder <elder@xxxxxxxxxx>
>
> > ---
> >   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml 
> > b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> > index b8a0b392b24e..b86edf67ce62 100644
> > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> > @@ -64,7 +64,8 @@ properties:
> >         - const: gsi
> >       iommus:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 2
> >       clocks:
> >       maxItems: 1