Re: [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines

From: Qian Cai
Date: Tue Oct 26 2021 - 15:33:59 EST




On 10/26/21 3:21 PM, Andy Shevchenko wrote:
> Can you explain to me how it is supposed to work?
>
> For example,
>
> x = 0xaa55;
> size = 5;
>
> printf("%lu\n", find_first_bit(&x, size));
>
> In the resulting code we will always have 5 as the result,
> but is it correct one?

Sorry, my bad. GENMASK(size - 1, 0) would just become __GENMASK(size -
1, 0) instead of 0. Let me revisit it and run some tests first.