Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up

[Bjorn Helgaas]

On Mon, Oct 25, 2021 at 02:35:36AM +0000, Richard Zhu wrote:
> > -----Original Message-----
> > From: Krzysztof Wilczyński <kw@xxxxxxxxx>
> > Sent: Saturday, October 23, 2021 5:54 PM
> > To: Richard Zhu <hongxing.zhu@xxxxxxx>
> > Cc: Bjorn Helgaas <helgaas@xxxxxxxxxx>; l.stach@xxxxxxxxxxxxxx;
> > bhelgaas@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> > dl-linux-imx <linux-imx@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx
> > Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
> > unbalance when link never came up

> > I hope you don't mind me asking, but how is an empty default case in the
> > switch statement helping IMX6Q and IMX6QP?  What does it achieve for
> > these two controllers specifically?
> > 
> [Richard Zhu] Never mind. 😊.
> There might be following building warning if the "default:break" is removed.
> "  CC      drivers/pci/controller/dwc/pci-imx6.o
> drivers/pci/controller/dwc/pci-imx6.c: In function ‘imx6_pcie_clk_disable’:
> drivers/pci/controller/dwc/pci-imx6.c:527:2: warning: enumeration value ‘IMX6Q’ not handled in switch [-Wswitch]
>   527 |  switch (imx6_pcie->drvdata->variant) {
>       |  ^~~~~~
> drivers/pci/controller/dwc/pci-imx6.c:527:2: warning: enumeration value ‘IMX6QP’ not handled in switch [-Wswitch]"

Sorry, I didn't see this until after asking the same question as
Krzysztof.

Sigh.  That's a really annoying gcc warning, but I guess I won't fight
it ;)

Bjorn