Re: [PATCH net-next] xdp: Remove redundant warning
From: Jesper Dangaard Brouer
Date: Wed Oct 27 2021 - 02:21:08 EST
On 27/10/2021 03.38, Yajun Deng wrote:
There is a warning in xdp_rxq_info_unreg_mem_model() when reg_state isn't
equal to REG_STATE_REGISTERED, so the warning in xdp_rxq_info_unreg() is
redundant.
>
Signed-off-by: Yajun Deng <yajun.deng@xxxxxxxxx>
Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
I guess/wonder if we should mark this as a fix for:
Fixes: dce5bd6140a4 ("xdp: export xdp_rxq_info_unreg_mem_model")
---
net/core/xdp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/xdp.c b/net/core/xdp.c
index cc92ccb38432..5ddc29f29bad 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -143,8 +143,6 @@ void xdp_rxq_info_unreg(struct xdp_rxq_info *xdp_rxq)
if (xdp_rxq->reg_state == REG_STATE_UNUSED)
return;
- WARN(!(xdp_rxq->reg_state == REG_STATE_REGISTERED), "Driver BUG");
-
xdp_rxq_info_unreg_mem_model(xdp_rxq);
xdp_rxq->reg_state = REG_STATE_UNREGISTERED;