Re: [PATCH v1] can: etas_es58x: es58x_rx_err_msg: fix memory leak in error path

[Marc Kleine-Budde]

On 27.10.2021 03:07:40, Vincent Mailhol wrote:
> In es58x_rx_err_msg(), if can->do_set_mode() fails, the function
> directly returns without calling netif_rx(skb). This means that the
> skb previously allocated by alloc_can_err_skb() is not freed. In other
> terms, this is a memory leak.
> 
> This patch simply removes the return statement in the error branch and
> let the function continue.
> 
> * Appendix: how the issue was found *

Thanks for the explanation, but I think I'll remove the appendix while
applying.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature