Re: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c

From: Peter Korsgaard
Date: Wed Oct 27 2021 - 04:20:02 EST


>>>>> "cgel" == cgel zte <cgel.zte@xxxxxxxxx> writes:

> From: ran jianping <ran.jianping@xxxxxxxxxx>
> 'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
> is duplicated.It is also included on the 17 line.

> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ran jianping <ran.jianping@xxxxxxxxxx>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)

> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>

It probably makes more sense to drop the include from line 17 to keep
alphabetical ordering, but otherwise it looks good to.

With that fixed:

Acked-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>

--
Bye, Peter Korsgaard