Re: [PATCH v1 1/1] PCI: brcmstb: Use GENMASK() as __GENMASK() is for internal use only

From: Andy Shevchenko
Date: Wed Oct 27 2021 - 06:31:35 EST


On Wed, Oct 27, 2021 at 01:27:19PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 27, 2021 at 12:00:16PM +0200, Krzysztof Wilczyński wrote:

...

> (and I truly believe the code is very ugly here, because

s/code/generated code/

> the idea behind GENMASK() is to be used with constants).

--
With Best Regards,
Andy Shevchenko