Re: [PATCH 2/2] dt-bindings: Migrate DA9063 text bindings to YAML
From: Rob Herring
Date: Wed Oct 27 2021 - 10:12:33 EST
On Wed, 27 Oct 2021 07:23:23 +0200, Alexandre Ghiti wrote:
> DA9063 devices bindings used text format, so migrate those bindings to YAML
> format before adding any new bindings.
>
> Signed-off-by: Alexandre Ghiti <alexandre.ghiti@xxxxxxxxxxxxx>
> ---
> .../bindings/input/da9063-onkey.yaml | 39 ++++++
> .../devicetree/bindings/mfd/da9063.txt | 111 ------------------
> .../devicetree/bindings/mfd/da9063.yaml | 98 ++++++++++++++++
> .../bindings/regulator/da9063-regulator.yaml | 51 ++++++++
> .../devicetree/bindings/rtc/da9063-rtc.yaml | 31 +++++
> .../bindings/watchdog/da9063-watchdog.yaml | 31 +++++
> 6 files changed, 250 insertions(+), 111 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/da9063-onkey.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/da9063.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/da9063.yaml
> create mode 100644 Documentation/devicetree/bindings/regulator/da9063-regulator.yaml
> create mode 100644 Documentation/devicetree/bindings/rtc/da9063-rtc.yaml
> create mode 100644 Documentation/devicetree/bindings/watchdog/da9063-watchdog.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/mfd/da9063.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/mfd/da9063.yaml:27:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/mfd/da9063.example.dts:21.17-18 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/mfd/da9063.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1441: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/input/da9062-onkey.txt: Documentation/devicetree/bindings/mfd/da9063.txt
See https://patchwork.ozlabs.org/patch/1546751
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.