Re: dt-bindings: treewide: Update @st.com email address to @foss.st.com
From: Joe Perches
Date: Wed Oct 27 2021 - 12:58:50 EST
On Wed, 2021-10-27 at 15:56 +0200, Patrice CHOTARD wrote:
> On 10/27/21 8:11 AM, Patrice CHOTARD wrote:
> > On 10/20/21 1:39 PM, Marc Zyngier wrote:
> > > On Wed, 20 Oct 2021 08:45:02 +0100,
> > > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
> > > > On 20/10/2021 08:50, patrice.chotard@xxxxxxxxxxx wrote:
> > > > > From: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
> > > > >
> > > > > Not all @st.com email address are concerned, only people who have
> > > > > a specific @foss.st.com email will see their entry updated.
> > > > > For some people, who left the company, remove their email.
> > > > Also would be nice to see here explained *why* are you doing this.
> > >
> > > And why this can't be done with a single update to .mailmap, like
> > > anyone else does.
> >
> > Thanks for the tips, yes, it will be simpler.
>
> I made a try by updating .mailmap with adding a new entry with my @foss.st.com email :
>
> Pali Rohár <pali@xxxxxxxxxx> <pali.rohar@xxxxxxxxx>
> Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
> +Patrice Chotard <patrice.chotard@xxxxxxxxxxx> <patrice.chotard@xxxxxx>
> Patrick Mochel <mochel@xxxxxxxxxxxxxxxxxx>
> Paul Burton <paulburton@xxxxxxxxxx> <paul.burton@xxxxxxxxxx>
>
> But when running ./scripts/get_maintainer.pl Documentation/devicetree/bindings/arm/sti.yaml, by old email is still displayed
>
> Rob Herring <robh+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Patrice Chotard <patrice.chotard@xxxxxx> (in file)
> devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> By default, the get_maintainer.pl script is using .mailmap file ($email_use_mailmap = 1).
>
> It seems there is an issue with get_maintainer.pl and maintainer name/e-mail found in yaml file ?
I'm of two minds whether it's an "issue" actually.
get_maintainer is not the only tool used to create email
address lists.
Some actually read files like MAINTAINERS or .dts or .yaml
files directly to find maintainer addresses.
So If your name and email address is listed in an source file
where nominally active email addresses are entered then I
believe .mailmap should not modify it.
So I believe email addresses in each file should be updated
in preference to using a mailmap entry for nominally active
email addresses in these files.
---
$ cat Documentation/devicetree/bindings/arm/sti.yaml
# SPDX-License-Identifier: GPL-2.0
%YAML 1.2
---
$id: http://devicetree.org/schemas/arm/sti.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: ST STi Platforms Device Tree Bindings
maintainers:
- Patrice Chotard <patrice.chotard@xxxxxx>