Re: [GIT PULL v2] Coresight changes for v5.16

[Mathieu Poirier]

On Wed, 27 Oct 2021 at 00:50, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Oct 26, 2021 at 01:55:45PM -0600, Mathieu Poirier wrote:
> > The following changes since commit 5816b3e6577eaa676ceb00a848f0fd65fe2adc29:
> >
> >   Linux 5.15-rc3 (2021-09-26 14:08:19 -0700)
> >
> > are available in the Git repository at:
> >
> >   git@xxxxxxxxxxxxxxxxxxx:pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.16
>
> Better but I get the following errors when my scripts try to merge them.
> Note, the linux-next scripts will give you the same complaint, so this
> isn't a new thing:

Can you point me to the linux-next script you are referring to above?
Usually when that happens I get an email but this time I didn't get
anything.

>
> Commit 6871138a7ab9 ("coresight: etm4x: Add ETM PID for Kryo-5XX")
>         committer Signed-off-by missing
>         author email:    quic_taozha@xxxxxxxxxxx
>         committer email: mathieu.poirier@xxxxxxxxxx
>         Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
>         Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Commit 202d403ae3a9 ("coresight: Don't immediately close events that are run on invalid CPU/sink combos")
>         committer Signed-off-by missing
>         author email:    james.clark@xxxxxxx
>         committer email: mathieu.poirier@xxxxxxxxxx
>         Signed-off-by: James Clark <james.clark@xxxxxxx>
>         Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Commit ef095e61dc8f ("coresight: Update comments for removing cs_etm_find_snapshot()")
>         committer Signed-off-by missing
>         author email:    leo.yan@xxxxxxxxxx
>         committer email: mathieu.poirier@xxxxxxxxxx
>         Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
>         Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Commit 7be15eef996f ("coresight: tmc-etr: Use perf_output_handle::head for AUX ring buffer")
>         committer Signed-off-by missing
>         author email:    leo.yan@xxxxxxxxxx
>         committer email: mathieu.poirier@xxxxxxxxxx
>         Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
>         Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Commit 60067d5ab339 ("coresight: tmc-etf: Add comment for store ordering")
>         committer Signed-off-by missing
>         author email:    leo.yan@xxxxxxxxxx
>         committer email: mathieu.poirier@xxxxxxxxxx
>         Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
>         Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Commit 7c202525ff8c ("coresight: tmc-etr: Add barrier after updating AUX ring buffer")
>         committer Signed-off-by missing
>         author email:    leo.yan@xxxxxxxxxx
>         committer email: mathieu.poirier@xxxxxxxxxx
>         Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
>         Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Errors in tree with Signed-off-by, please fix!
>
>
> Is there some reason you are committing changes to your tree and not signing
> off on them?  That's not really a good idea :(
>

Not sure why sarcasm is required here - simply pointing out the
problem would have been sufficient.

These patches were committed by Suzuki who co-maintains the subsystem
with me.  The committer information likely got transferred when I
cherry-picked the patches when putting the pull request together.

> thanks,
>
> greg k-h