Re: [PATCH 1/1] include/linux/byteorder/generic.h: fix index variables

From: Heinrich Schuchardt
Date: Wed Oct 27 2021 - 14:27:47 EST


On 5/23/21 22:49, Heinrich Schuchardt wrote:
In cpu_to_be32_array() and be32_to_cpu_array() the length of the array is
given by variable len of type size_t. An index variable of type int is used
to iterate over the array. This is bound to fail for len > INT_MAX and
lets GCC add instructions for sign extension.

Correct the type of the index variable.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
---
include/linux/byteorder/generic.h | 4 ++--

Dear Greg,

This file is not assigned to any maintainer. Could you handle the patch?

Best regards

Heinrich

1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
index 4b13e0a3e15b..c9a4c96c9943 100644
--- a/include/linux/byteorder/generic.h
+++ b/include/linux/byteorder/generic.h
@@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)

static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
{
- int i;
+ size_t i;

for (i = 0; i < len; i++)
dst[i] = cpu_to_be32(src[i]);
@@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)

static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len)
{
- int i;
+ size_t i;

for (i = 0; i < len; i++)
dst[i] = be32_to_cpu(src[i]);
--
2.30.2