Re: [PATCH] ACPI: glue: Use acpi_device_adr() in acpi_find_child_device()

[Andy Shevchenko]

On Wed, Oct 27, 2021 at 07:23:43PM +0200, Rafael J. Wysocki wrote:
> On Wed, Oct 27, 2021 at 7:17 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Oct 27, 2021 at 06:59:06PM +0200, Rafael J. Wysocki wrote:

...

> See acpi_set_pnp_ids().
> 
> adev->pnp.bus_addres is the address value and
> adev->pnp.type.bus_address is a flag that is set to 1 when _ADR is
> valid.
> 
> > IIUC _ADR == 0 is a valid value and children may have it like this.
> 
> That's true.
> 
> > I believe this change will break the working things (first comes to my mind
> > is drivers/mfd/intel_quark_i2c_gpio.c).
> 
> I don't think so.

With your explanation I see where my logic is wrong. Thanks!

-- 
With Best Regards,
Andy Shevchenko