Re: [PATCH v4 1/3] PM / wakeirq: support enabling wake-up irq after runtime_suspend called

[Rafael J. Wysocki]

On Wed, Oct 27, 2021 at 11:34 AM Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote:
>
> On Tue, 2021-10-26 at 17:39 +0200, Rafael J. Wysocki wrote:
> > On Mon, Oct 25, 2021 at 9:02 AM Chunfeng Yun <
> > chunfeng.yun@xxxxxxxxxxxx> wrote:
> > >
> > > When the dedicated wake IRQ is level trigger, and it uses the
> > > device's low-power status as the wakeup source, that means if the
> > > device is not in low-power state, the wake IRQ will be triggered
> > > if enabled; For this case, need enable the wake IRQ after running
> > > the device's ->runtime_suspend() which make it enter low-power
> > > state.
> > >
> > > e.g.
> > > Assume the wake IRQ is a low level trigger type, and the wakeup
> > > signal comes from the low-power status of the device.
> > > The wakeup signal is low level at running time (0), and becomes
> > > high level when the device enters low-power state (runtime_suspend
> > > (1) is called), a wakeup event at (2) make the device exit low-
> > > power
> > > state, then the wakeup signal also becomes low level.
> > >
> > >                 ------------------
> > >                |           ^     ^|
> > > ----------------           |     | --------------
> > >  |<---(0)--->|<--(1)--|   (3)   (2)    (4)
> > >
> > > if enable the wake IRQ before running runtime_suspend during (0),
> > > a wake IRQ will arise, it causes resume immediately;
> > > it works if enable wake IRQ ( e.g. at (3) or (4)) after running
> > > ->runtime_suspend().
> > >
> > > This patch introduces a new status WAKE_IRQ_DEDICATED_REVERSE to
> > > optionally support enabling wake IRQ after running
> > > ->runtime_suspend().
> > >
> > > Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> >
> > I don't really have anything to add regarding the code.
> >
> > The kerneldoc comments could be improved, but I can take care of this
> > when applying the patch.
> Ok, thanks
> >
> > Please collect ACKs for the remaining 2 patches in the series and I
> > will pick up all three.
> The files (mtu3_plat.c, xhci-mtk.c) modified by other 2 patches are
> maintained by myself, please pick up them, thanks a lot.

OK, applied as 5.16 material, thanks!