Re: [PATCH V3 0/6] perf dlfilter: Add dlfilter-show-cycles

From: Arnaldo Carvalho de Melo
Date: Wed Oct 27 2021 - 15:18:42 EST


Em Wed, Oct 27, 2021 at 11:03:28AM +0300, Adrian Hunter escreveu:
> Hi
>
> The issue with V1 was that the IPC information used to accumulate cycle
> counts has a lower granularity because it is output only when the cycle
> count correlates to the IP of the event i.e. only when the IPC is exactly
> correct.
>
> To enable more frequent updates to the cycle count, itrace option 'A' is
> added, which specifies that IPC information can be approximate.
>
> In addition there are some new miscellaneous patches.

Ok, replacing v2 with this one.

>
> Changes in V3:
>
> perf intel-pt: Support itrace A option to approximate IPC
> Expanded explanation of the loss of accuracy of IPC with 'A' option.
>
> Added Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
>
> Changes in V2:
>
> perf dlfilter: Add dlfilter-show-cycles
> Separate counts for branches, instructions or other events.
>
> New patches:
> perf auxtrace: Add missing Z option to ITRACE_HELP
> perf auxtrace: Add itrace A option to approximate IPC
> perf intel-pt: Support itrace A option to approximate IPC
> perf auxtrace: Add itrace d+o option to direct debug log to stdout
> perf intel-pt: Support itrace d+o option to direct debug log to stdout
>
>
> Adrian Hunter (6):
> perf auxtrace: Add missing Z option to ITRACE_HELP
> perf auxtrace: Add itrace A option to approximate IPC
> perf intel-pt: Support itrace A option to approximate IPC
> perf dlfilter: Add dlfilter-show-cycles
> perf auxtrace: Add itrace d+o option to direct debug log to stdout
> perf intel-pt: Support itrace d+o option to direct debug log to stdout
>
> tools/perf/Documentation/itrace.txt | 2 +
> tools/perf/Documentation/perf-intel-pt.txt | 28 ++++
> tools/perf/Makefile.perf | 2 +-
> tools/perf/dlfilters/dlfilter-show-cycles.c | 144 +++++++++++++++++++++
> tools/perf/util/auxtrace.c | 3 +
> tools/perf/util/auxtrace.h | 6 +
> .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 1 +
> .../perf/util/intel-pt-decoder/intel-pt-decoder.h | 1 +
> tools/perf/util/intel-pt-decoder/intel-pt-log.c | 8 +-
> tools/perf/util/intel-pt.c | 21 ++-
> 10 files changed, 205 insertions(+), 11 deletions(-)
> create mode 100644 tools/perf/dlfilters/dlfilter-show-cycles.c
>
>
> Regards
> Adrian

--

- Arnaldo