Re: [PATCH 0/3] tracing/kselftest: histogram trigger expression tests

From: Kalesh Singh
Date: Wed Oct 27 2021 - 17:04:29 EST


On Wed, Oct 27, 2021 at 1:59 PM Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:
>
> This series adds kselftest for histogram trigger expresions and is
> dependent on the series at [1] and can be applied on top of those after
> dropping the patch 7 in [1].
>
> [1] https://lore.kernel.org/r/20211025200852.3002369-1-kaleshsingh@xxxxxxxxxx/
>
> Kalesh Singh (3):
> tracing/histogram: Document hist trigger variables
> tracing/kselftests: Remove triggers with references before their
> definitions
> tracing/selftests: Add tests for hist trigger expression parsing (v5)

Hi Steve, Masami,

Can you give these changes a try when you can please. I believe it
should not cause any regressions now.

Thanks,
Kalesh
>
> kernel/trace/trace.c | 11 +++
> .../testing/selftests/ftrace/test.d/functions | 9 +++
> .../trigger/trigger-hist-expressions.tc | 72 +++++++++++++++++++
> 3 files changed, 92 insertions(+)
> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-expressions.tc
>
> --
> 2.33.0.1079.g6e70778dc9-goog
>