Re: [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names

[Rob Herring]

On Mon, Oct 25, 2021 at 12:57:18AM +0300, Dmitry Osipenko wrote:
> Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP
> tables use multi-word names where first part is freq and second voltage
> because different hardware versions use different voltages for the same
> freqs. Allow OPP entry to have multi-worded name separated by hyphen.
> This silences DT checker warnings about wrong naming scheme.
> 
> Reviewed-by: David Heidelberg <david@xxxxxxx>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> 
> Changelog:
> 
> v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
>       I dropped variant with postfix naming scheme and multi-wording
>       support of table names.
> 
> v2: - In addition to a multi-wording support, support of the postfix
>       *-opp-table naming scheme is added to the updated pattern.
> 
>  Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index ae3ae4d39843..f79343960539 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -33,7 +33,7 @@ properties:
>      type: boolean
>  
>  patternProperties:
> -  '^opp-?[0-9]+$':
> +  '^opp(-[0-9]+)*$':

This drops support for cases like 'opp1' which there are a ton of. It 
should be '^opp(-?[0-9]+)*$' if we want to keep that support.

I'd love to be stricter, but trying to find a balance.

Rob