Re: [PATCH v2 1/3] ath10k: fix division by zero in send path

From: Kalle Valo
Date: Thu Oct 28 2021 - 03:34:43 EST


Johan Hovold <johan@xxxxxxxxxx> wrote:

> Add the missing endpoint max-packet sanity check to probe() to avoid
> division by zero in ath10k_usb_hif_tx_sg() in case a malicious device
> has broken descriptors (or when doing descriptor fuzz testing).
>
> Note that USB core will reject URBs submitted for endpoints with zero
> wMaxPacketSize but that drivers doing packet-size calculations still
> need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
> endpoint descriptors with maxpacket=0")).
>
> Fixes: 4db66499df91 ("ath10k: add initial USB support")
> Cc: stable@xxxxxxxxxxxxxxx # 4.14
> Cc: Erik Stromdahl <erik.stromdahl@xxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

2 patches applied to ath-next branch of ath.git, thanks.

a006acb93131 ath10k: fix division by zero in send path
c1b9ca365dea ath6kl: fix division by zero in send path

--
https://patchwork.kernel.org/project/linux-wireless/patch/20211027080819.6675-2-johan@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches