Re: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc

From: H. Nikolaus Schaller
Date: Thu Oct 28 2021 - 06:07:53 EST




> Am 28.10.2021 um 11:55 schrieb Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>:
>
> On Thursday 28 October 2021 11:40:59 CEST H. Nikolaus Schaller wrote:
>>> Am 28.10.2021 um 10:59 schrieb Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>:
>>> On Thursday 28 October 2021 09:08:50 CEST H. Nikolaus Schaller wrote:
>>>
>>>>> Let me have a closer look - and for sure, I am willing to help if needed.
>>>
>>> I confirm it does not have the expected behavior. !mmc_fixup_of_compatible_match()
>>> should be mmc_fixup_of_compatible_match(), sorry.
>>
>> Ok, I see.
>>
>> One more question: how can I specify "ti,wl1251" in some struct mmc_fixup table?
>> Does it need another macro like MMC_FIXUP() or SDIO_FIXUP() to set the .name
>> field?
>
> yes, I didn't provide it with my RFC.

I see.

Starts to look like a good plan and we just have to execute it.

Please notify if you have a new version to work with (it isn't urgent since the
transplantation is only needed if omap_hsmmc is retired which depends on merge
of the new driver).

BR and thanks,
Nikolaus