RE: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading

[pillair]

> -----Original Message-----
> From: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Sent: Friday, October 8, 2021 12:05 AM
> To: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>; agross@xxxxxxxxxx;
> bjorn.andersson@xxxxxxxxxx; mathieu.poirier@xxxxxxxxxx; ohad@xxxxxxxxxx;
> p.zabel@xxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; sibis@xxxxxxxxxxxxxx; mpubbise@xxxxxxxxxxxxxx;
> kuabhs@xxxxxxxxxxxx
> Subject: Re: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading
> 
> Quoting Rakesh Pillai (2021-10-03 23:48:50)
> > Add support for PIL loading of WPSS co-processor for SC7280 SOCs.
> >
> > Changes from v4/v5:
> > - Add yaml conversion for adsp/cdsp dt-bindings
> > - Change clock names in wpss dt-bindings
> > - Correct mistake in signed-off enail ID
> 
> Can you keep a running tally here of the full progression of the series?
> That helps to look back and make sure we don't make a comment that has
> already been made before.
> 
> One more request. Can you add support for 'firmware-name' like there is in
> Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt so that we
> can install firmware into some namespaced/versioned place instead of
> having to put wpss files into /lib/firmware? 

Hi Stephen,
I have posted v7 with the support for firmware-name to be provided in the DT entry.

> It would also be nice to load a
> single firmware file instead of having to split the file into many pieces.

This would require lot of changes and lot of code duplication from request firmware.
Also the base ath11k firmware files have been posted as split files.


Thanks,
Rakesh Pillai