Re: [PATCH 1/3] media: mtk-vcodec: enc: add vp8 profile ctrl

[Nicolas Dufresne]

Le vendredi 22 octobre 2021 à 17:04 +0200, Dafna Hirschfeld a écrit :
> In order for the encoder to work with gstreamer
> it needs to have the V4L2_CID_MPEG_VIDEO_VP8_PROFILE
> ctrl. This patch adds that ctrl with only profile 0
> supported.
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>

I confirm starting from GStreamer 1.18 profile (and level for other codecs) are
needed. This is to allow proper fallback to other decoders (including software)
when the HW is not capable.

Acked-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>

> ---
>  drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> index 8998244ea671..87a5114bf680 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> @@ -103,6 +103,13 @@ static int vidioc_venc_s_ctrl(struct v4l2_ctrl *ctrl)
>  		p->gop_size = ctrl->val;
>  		ctx->param_change |= MTK_ENCODE_PARAM_GOP_SIZE;
>  		break;
> +	case V4L2_CID_MPEG_VIDEO_VP8_PROFILE:
> +		/*
> +		 * FIXME - what vp8 profiles are actually supported?
> +		 * The ctrl is added (with only profile 0 supported) for now.
> +		 */
> +		mtk_v4l2_debug(2, "V4L2_CID_MPEG_VIDEO_VP8_PROFILE val = %d", ctrl->val);
> +		break;
>  	case V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME:
>  		mtk_v4l2_debug(2, "V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME");
>  		p->force_intra = 1;
> @@ -1394,6 +1401,9 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx)
>  	v4l2_ctrl_new_std_menu(handler, ops, V4L2_CID_MPEG_VIDEO_H264_LEVEL,
>  			       h264_max_level,
>  			       0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
> +	v4l2_ctrl_new_std_menu(handler, ops, V4L2_CID_MPEG_VIDEO_VP8_PROFILE,
> +			       V4L2_MPEG_VIDEO_VP8_PROFILE_0, 0, V4L2_MPEG_VIDEO_VP8_PROFILE_0);
> +
>  
>  	if (handler->error) {
>  		mtk_v4l2_err("Init control handler fail %d",