Re: [PATCH] Staging: greybus: audio_codec: changed a void function to return 0

From: Bryan Brattlof
Date: Thu Oct 28 2021 - 12:35:40 EST


Hi Senthu,

On this day, October 28, 2021, thus sayeth Senthu Sivarajah:
> From: Senthuran Sivarajah <ssivaraj@xxxxxxxxxxxxxxx>
>
> Fixed a coding style issue.
>
> Signed-off-by: Senthuran Sivarajah <ssivaraj@xxxxxxxxxxxxxxx>
>
> ---
> drivers/staging/greybus/audio_codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..9f99862791dc 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1028,7 +1028,7 @@ static int gbcodec_probe(struct snd_soc_component *comp)
> static void gbcodec_remove(struct snd_soc_component *comp)
^^^^

If I'm not mistaken here, our options are to remove the return or just
leave this as is. IMO I think this is fine as is.

~Bryan