Re: [PATCH v6 3/3] Bluetooth: btusb: enable Mediatek to support AOSP extension

From: Marcel Holtmann
Date: Fri Oct 29 2021 - 04:21:50 EST


Hi Joseph,

> Some of Mediatek's controllers/firmwares do NOT support AOSP extensions.
>
> Please refer to this Gerrit patch review link for chrome os
> (https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3054233/8/drivers/bluetooth/btusb.c)
> which was reviewed by Mark-YW Chen, Mediatek's engineer.
>
> As an example, MediaTek MT7615E does not support the AOSP extensions.
>
> That was why I used a new BTUSB_QUALITY_REPORT flag in the changes v4
> and earlier ones.
>
> Please let me know how you would like to proceed with this patch.

I want that inside the Mediatek specific hdev->setup() procedure, they decide if AOSP extensions are supported or not. The BTUSB flag business is getting out of hand. I really don’t want that in btusb.c anymore. I moved Intel over to do that in btintel.c and also Realtek is doing it in btrtl.c for their hardware with the MSFT extensions.

We are not doing try-and-error of HCI commands. Just keep that in mind since I said that multiple times now.

Regards

Marcel