Re: [PATCH -next] HID: nintendo: fix missing unlock on error in joycon_leds_create()

[Silvan Jegen]

On Fri, Oct 29, 2021 at 5:04 AM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
>
> Add the missing unlock before return from function joycon_leds_create()
> in the error handling case.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: c5e626769563 ("HID: nintendo: add player led support")
> Fixes: 697e5c7a34b0 ("HID: nintendo: add home led support")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>  drivers/hid/hid-nintendo.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)

LGTM!

For what it's worth:

Reviewed-by: Silvan Jegen <s.jegen@xxxxxxxxx>


Cheers,
Silvan