Re: [PATCH] [RFC] arm64: export this_cpu_has_cap

From: Suzuki K Poulose
Date: Fri Oct 29 2021 - 09:31:29 EST


Hi Arnd

Thanks for the fix.

On 29/10/2021 12:30, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>

It's now used in a coresight driver that can be a loadable module:

ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!

Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")

Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
Tested-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>

Will, Catalin, Mathieu,

Do you have a preference on how this fix can be pulled in ? This may
be safe to go via coresight tree if it is not too late. Otherwise,
it could go via the arm64 tree.

Suzuki

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
Not sure if we actually want this to be exported, this is my local
workaround for the randconfig build bot.
---
arch/arm64/kernel/cpufeature.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index ecbdff795f5e..beccbcfa7391 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
return false;
}
+EXPORT_SYMBOL(this_cpu_has_cap);
/*
* This helper function is used in a narrow window when,