Re: [PATCH v5 2/2] pinctrl: amd: Fix wakeups when IRQ is shared with SCI

From: kernel test robot
Date: Fri Oct 29 2021 - 11:03:11 EST

Hi Mario,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on rafael-pm/linux-next linus/master v5.15-rc7 next-20211028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mario-Limonciello/ACPI-Add-stubs-for-wakeup-handler-functions/20211028-224738
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/aa823b07a228116ebb416d3c49ec526e78c6c138
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mario-Limonciello/ACPI-Add-stubs-for-wakeup-handler-functions/20211028-224738
git checkout aa823b07a228116ebb416d3c49ec526e78c6c138
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from include/linux/printk.h:555,
from include/asm-generic/bug.h:22,
from arch/powerpc/include/asm/bug.h:149,
from include/linux/bug.h:5,
from drivers/pinctrl/pinctrl-amd.c:14:
drivers/pinctrl/pinctrl-amd.c: In function '_amd_gpio_irq_handler':
>> drivers/pinctrl/pinctrl-amd.c:625:41: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Werror=format=]
625 | "Waking due to GPIO %ld: 0x%x",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/pinctrl/pinctrl-amd.c:624:33: note: in expansion of macro 'dev_dbg'
624 | dev_dbg(&gpio_dev->pdev->dev,
| ^~~~~~~
drivers/pinctrl/pinctrl-amd.c:625:63: note: format string is defined here
625 | "Waking due to GPIO %ld: 0x%x",
| ~~^
| |
| long int
| %d
drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_probe':
drivers/pinctrl/pinctrl-amd.c:1019:46: error: 'struct amd_gpio' has no member named 'irq'
1019 | acpi_register_wakeup_handler(gpio_dev->irq, amd_gpio_check_wake, gpio_dev);
| ^~
cc1: all warnings being treated as errors


vim +625 drivers/pinctrl/pinctrl-amd.c

590
591 static bool _amd_gpio_irq_handler(int irq, void *dev_id)
592 {
593 struct amd_gpio *gpio_dev = dev_id;
594 struct gpio_chip *gc = &gpio_dev->gc;
595 unsigned int i, irqnr;
596 unsigned long flags;
597 u32 __iomem *regs;
598 bool ret = false;
599 u32 regval;
600 u64 status, mask;
601
602 /* Read the wake status */
603 raw_spin_lock_irqsave(&gpio_dev->lock, flags);
604 status = readl(gpio_dev->base + WAKE_INT_STATUS_REG1);
605 status <<= 32;
606 status |= readl(gpio_dev->base + WAKE_INT_STATUS_REG0);
607 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
608
609 /* Bit 0-45 contain the relevant status bits */
610 status &= (1ULL << 46) - 1;
611 regs = gpio_dev->base;
612 for (mask = 1, irqnr = 0; status; mask <<= 1, regs += 4, irqnr += 4) {
613 if (!(status & mask))
614 continue;
615 status &= ~mask;
616
617 /* Each status bit covers four pins */
618 for (i = 0; i < 4; i++) {
619 regval = readl(regs + i);
620 /* called from resume context on a shared IRQ, just
621 * checking wake source.
622 */
623 if (irq < 0 && (regval & BIT(WAKE_STS_OFF))) {
624 dev_dbg(&gpio_dev->pdev->dev,
> 625 "Waking due to GPIO %ld: 0x%x",
626 regs + i - ((u32 __iomem *)gpio_dev->base), regval);
627 return true;
628 }
629
630 if (!(regval & PIN_IRQ_PENDING) ||
631 !(regval & BIT(INTERRUPT_MASK_OFF)))
632 continue;
633 generic_handle_domain_irq(gc->irq.domain, irqnr + i);
634
635 /* Clear interrupt.
636 * We must read the pin register again, in case the
637 * value was changed while executing
638 * generic_handle_domain_irq() above.
639 * If we didn't find a mapping for the interrupt,
640 * disable it in order to avoid a system hang caused
641 * by an interrupt storm.
642 */
643 raw_spin_lock_irqsave(&gpio_dev->lock, flags);
644 regval = readl(regs + i);
645 if (irq == 0) {
646 regval &= ~BIT(INTERRUPT_ENABLE_OFF);
647 dev_dbg(&gpio_dev->pdev->dev,
648 "Disabling spurious GPIO IRQ %d\n",
649 irqnr + i);
650 }
651 writel(regval, regs + i);
652 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
653 ret = true;
654 }
655 }
656 /* called from resume context on shared IRQ but didn't cause wake */
657 if (irq < 0)
658 return false;
659
660 /* Signal EOI to the GPIO unit */
661 raw_spin_lock_irqsave(&gpio_dev->lock, flags);
662 regval = readl(gpio_dev->base + WAKE_INT_MASTER_REG);
663 regval |= EOI_MASK;
664 writel(regval, gpio_dev->base + WAKE_INT_MASTER_REG);
665 raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
666
667 return ret;
668 }
669

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip