Re: [PATCH V6 11/20] rtla/osnoise: Add the hist mode

From: Daniel Bristot de Oliveira
Date: Fri Oct 29 2021 - 12:29:14 EST


On 10/27/21 20:29, Steven Rostedt wrote:
> On Thu, 28 Oct 2021 02:11:24 +0800
> Tao Zhou <tao.zhou@xxxxxxxxx> wrote:
>
>>> + /* one histogram for IRQ and one for thread, per cpu */
>>> + for (cpu = 0; cpu < nr_cpus; cpu++) {
>>> + data->hist[cpu].samples = calloc(1, sizeof(*data->hist) * (entries + 1));
>> @samples is a pointer to int and used for int array. The "sizeof(*data->hist)"
>> should be "sizeof(int)" or am I totally wrong.
> Or standard approach is:
>
> data->hist[cpu].samples = calloc(1, sizeof(*data->hist->samples) * (entries + 1));

Fixed in the next version, thanks!

-- Daniel