Re: [PATCH v2 1/4] tracing/histogram: Optimize division by constants
From: Steven Rostedt
Date: Fri Oct 29 2021 - 16:25:55 EST
On Fri, 29 Oct 2021 11:53:16 -0700
Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:
> > If these functions are only called when val2 is constant, can't we make it
> > such that we get val2 from the hist_field directly? That is:
> >
> > u64 val2 = operand2->constant;
>
> operand2 might be a var ref to a constant, so we would need to resolve
> that with hist_field_var_ref().
So can a var_ref change? If not, then we should convert that to a constant
for this operation.
-- Steve