Re: [PATCH v5 0/2] gpio: mlxbf2: Introduce proper interrupt handling

From: Andy Shevchenko
Date: Fri Oct 29 2021 - 17:15:39 EST


On Fri, Oct 29, 2021 at 7:46 PM Asmaa Mnebhi <asmaa@xxxxxxxxxx> wrote:

> > This is a follow up on a discussion regarding proper handling of GPIO
> > interrupts within the gpio-mlxbf2.c driver.
> >
> > Link to discussion:
> > https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenk
> > o@xxxxxxxxxxxxxxx/T/
> >
> > Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c.
> > Patch 2 is a follow up removal of custom GPIO IRQ handling from the
> > mlxbf_gige driver and replacing it with a simple IRQ request. The ACPI
> > table for the mlxbf_gige driver is responsible for instantiating the
> > PHY GPIO interrupt via GpioInt.
> >
> > Andy Shevchenko, could you please review this patch series.
> > David Miller, could you please ack the changes in the mlxbf_gige
> > driver.

It looks nice! Thank you for fixing this code and making it right!

--
With Best Regards,
Andy Shevchenko