Re: [PATCH] soc/tegra: fix unmet dependency on DMADEVICES for TEGRA20_APB_DMA

From: Arnd Bergmann
Date: Fri Oct 29 2021 - 18:07:51 EST


On Fri, Oct 29, 2021 at 10:59 PM Julian Braha <julianbraha@xxxxxxxxx> wrote:
>
> drivers/soc/tegra/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index 8b53ed1cc67e..ee7f631933c2 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -136,7 +136,7 @@ config SOC_TEGRA_FUSE
> def_bool y
> depends on ARCH_TEGRA
> select SOC_BUS
> - select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
> + select TEGRA20_APB_DMA if DMADEVICES && ARCH_TEGRA_2x_SOC
>

Is this actually a compile-time dependency? If the fuse driver merely
uses DMA and assumes that the TEGRA20_APB_DMA driver is the one
providing this functionality, the 'select' should be removed here.

Arnd