Re: [PATCH] gpu/drm: ingenic: Remove bogus register write

From: Paul Cercueil
Date: Sat Oct 30 2021 - 16:04:00 EST


Hi,

Le sam., oct. 30 2021 at 20:49:53 +0200, Sam Ravnborg <sam@xxxxxxxxxxxx> a écrit :
Hi Paul,

On Sat, Oct 30, 2021 at 11:00:32AM +0100, Paul Cercueil wrote:
Commit 1bdb542da736 ("drm/ingenic: Simplify code by using hwdescs
array") caused the dma_hwdesc_phys_f{0,1} variables to be used while
uninitialized in a mmio register write, which most certainly broke the
ingenic-drm driver.

However, the very same patchset also submitted commit 6055466203df
("drm/ingenic: Upload palette before frame"), which restored a correct
behaviour by doing the register writes in a different place in the code.

What's left of this, is just to remove the bogus register writes in the
probe function.

Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>

Thank you lkp...
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Pushed to drm-misc-next.

Thanks!
-Paul