Re: [PATCH] parisc: using swap() instead of tmp

[Matthew Wilcox]

On Sun, Oct 31, 2021 at 07:10:45PM -0700, Yihao Han wrote:
> @@ -127,16 +127,13 @@ static void __init setup_bootmem(void)
>  		int j;
>  
>  		for (j = i; j > 0; j--) {
> -			physmem_range_t tmp;
>  

If you're going to delete that line, you should also delete the
blank line after it.

>  			if (pmem_ranges[j-1].start_pfn <
>  			    pmem_ranges[j].start_pfn) {
>  
>  				break;
>  			}
> -			tmp = pmem_ranges[j-1];
> -			pmem_ranges[j-1] = pmem_ranges[j];
> -			pmem_ranges[j] = tmp;
> +			swap(pmem_ranges[j-1], pmem_ranges[j]);
>  		}
>  	}
>  
> -- 
> 2.17.1
>