[PATCH] most: replace scnprintf in show functions with sysfs_emit
From: cgel . zte
Date: Mon Nov 01 2021 - 04:38:26 EST
From: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
Fix the coccicheck warning:
./drivers/most/most_usb.c: 834: 9-17: WARNING: use scnprintf or sprintf
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
---
drivers/most/most_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/most/most_usb.c b/drivers/most/most_usb.c
index 2640c5b326a4..0760fd141e4a 100644
--- a/drivers/most/most_usb.c
+++ b/drivers/most/most_usb.c
@@ -830,7 +830,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr,
int err;
if (sysfs_streq(name, "arb_address"))
- return snprintf(buf, PAGE_SIZE, "%04x\n", dci_obj->reg_addr);
+ return sysfs_emit(buf, "%04x\n", dci_obj->reg_addr);
if (sysfs_streq(name, "arb_value"))
reg_addr = dci_obj->reg_addr;
--
2.25.1