Re: Need help in debugging "memory leak in em28xx_init_dev"

[Dongliang Mu]

On Mon, Nov 1, 2021 at 5:19 PM Pavel Skripkin <paskripkin@xxxxxxxxx> wrote:
>
> On 11/1/21 11:55, Dongliang Mu wrote:
>
> >>
> >>
> >> Looks like missing clean up on error handling path.
> >>
> >> ->probe()
> >>      em28xx_init_dev()
> >>        em28xx_media_device_init() <- dev->media_dev allocated
> >>        *error somewhere in em28xx_init_dev()*
> >>
> >
> > Hi Pavel,
> >
> > you're right. In some error handling code (em28xx_audio_setup fails),
> > em28xx_init_dev fails to deallocated the media_dev field.
> >
>
> Hi, Dongliang,
>
> Did patch attached to my previous email pass syzbot's reproducer test?
> Unfortunately, I am not able to test rn :(

Yes, it works. The memory leak does not occur anymore.

But I am crafting another patch based on yours as there is a small
issue in the retval and I would like to make the error handling code
uniform.

>
>
>
>
> With regards,
> Pavel Skripkin