Re: [PATCH 09/13] arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT

From: Sugaya Taichi
Date: Mon Nov 01 2021 - 09:53:45 EST




On 2021/10/28 23:55, Arnd Bergmann wrote:
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote:

The patch series "Add basic support for Socionext Milbeaut M10V SoC" (see
Link) introduced the config ARCH_MILBEAUT_M10V "Milbeaut SC2000/M10V
platform" in ./arch/arm/mach-milbeaut/ and intended to introduce timer,
clock, pinctrl and serial controller drivers.

However, during patch submission in March 2019, the introduction of the
milbeaut pinctrl driver was dropped from v2 to v3 of the patch series.
Since then, there was no further patch series to add this pinctrl driver
later on.

Hence, selecting PINCTRL_MILBEAUT in config is simply dangling and
referring to a non-existing config symbols.
Fortunately, ./scripts/checkkconfigsymbols.py warns:

PINCTRL_MILBEAUT
Referencing files: arch/arm/mach-milbeaut/Kconfig

Remove this select of the non-existing PINCTRL_MILBEAUT for now.

Link: https://lore.kernel.org/linux-arm-kernel/1551243056-10521-1-git-send-email-sugaya.taichi@xxxxxxxxxxxxx/

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>

I would take that as an indication that there is no interest in supporting this
platform upstream any more, the version we merged probably never worked
without the rest of the drivers.

I've added the original authors of the other drivers to Cc. Should we remove
all of this?

Arnd


It is okay to drop PINCTRL_MILBEAUT. I will add it again when working at the pinctrl
driver. But don`t remove the milbeaut platform. Actually we haven't been doing
maintenance recently, but we have plans to add drivers in the future.

Thanks,
Taichi Sugaya