Re: [PATCH v4 10/11] platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell

[Andy Shevchenko]

On Mon, Nov 1, 2021 at 1:32 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 10/25/21 13:38, Andy Shevchenko wrote:
> > On Mon, Oct 25, 2021 at 12:42 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

...

> >> +       board_data = int3472_tps68470_get_board_data(dev_name(&client->dev));
> >
> >> +       if (board_data)
> >
> > IIRC it's a dup. Below already incorporates this.
> >
> >> +               gpiod_remove_lookup_table(board_data->tps68470_gpio_lookup_table);
>
> Not sure what you mean here? This line *dereferences* board_data, so even if
> gpiod_remove_lookup_table() already contains a NULL check for the table pointer,
> we still need the board_data check to avoid dereferencing it to get
> the tps68470_gpio_lookup_table member.

Oh, I see now. Nothing needs to be changed here.

-- 
With Best Regards,
Andy Shevchenko