Re: [PATCH] PCI: Marvell: Update PCIe fixup

From: Jason Gunthorpe
Date: Mon Nov 01 2021 - 12:27:18 EST


On Mon, Nov 01, 2021 at 04:04:05PM +0100, Pali Rohár wrote:
> - The code relies on rc_pci_fixup being called, which only happens
> when CONFIG_PCI_QUIRKS is enabled, so add that to Kconfig. Omitting
> this causes a booting failure with a non-obvious cause.
> - Update rc_pci_fixup to set the class properly, copying the
> more modern style from other places
> - Correct the rc_pci_fixup comment
>
> This patch just re-applies commit 1dc831bf53fd ("ARM: Kirkwood: Update
> PCI-E fixup") for all other Marvell platforms which use same buggy PCIe
> controller.

I wonder if that code is even relevant any more since we started using
CONFIG_PCI_MVEBU

?

Really, these broken controllers should not be used "raw" but always
via their special host bridge driver that fixes all the config space
problems.

Jason